Add ruff to lint stage, fix some discovered import/export issues etc.#744
Add ruff to lint stage, fix some discovered import/export issues etc.#744
Conversation
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
5ddc2c2 to
bc51c97
Compare
Ickerday
changed the title
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
bc51c97 to
4e405a1
Compare
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
4e405a1 to
f9b8a78
Compare
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
2 times, most recently
from
c4cd038 to
a8bbeca
Compare
… we don't use Windows, fix import/export errors, rewrite baseline
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
a8bbeca to
1bcf46c
Compare
|
Is this PR fully automatic, or are here any manual changes? Its hard for me to review this change. Please update the PR description to include such details what this change does. The best way to approach such changes is to separate these i.e. one PR (or just commit) that does a format and second that does changes to fix say lint issues required to enable it in CI, otherwise such PRs require huge review burden to get through merging it. Since now this change requires a review of every single file, instead of just the 2nd PR/commit and it is super easy to miss important changes, that are not related to formatting changes. |
| 'foo="f" boolean="f" code="foo == \\"bar\\"" duration="24:59:59" fieldname="some.field_name" ' | ||
| "file=" | ||
| + json_encode_string(__file__) | ||
| + encode_basestring_ascii(__file__) |
There was a problem hiding this comment.
I openned this file randomly and see a non-formatting change. Why we are doing this change here?
3 participants
No description provided.